Skip to content

Justify axis agnostic of label presence #6590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2025
Merged

Justify axis agnostic of label presence #6590

merged 3 commits into from
Oct 27, 2025

Conversation

@teunbrand
Copy link
Collaborator

@teunbrand teunbrand commented Sep 5, 2025 •
edited
Loading

This PR aims to fix #6574.

Essentially in #5826 I was too careful, to only apply justification if the axis had labels.
Now the justification is applied regardless of whether a guide has labels or not.

Reprex from issue:

devtools::load_all("~/packages/ggplot2/")
#> ℹ Loading ggplot2

ggplot(mtcars, aes(disp, mpg)) +
  geom_point() +
  coord_radial(r.axis.inside = TRUE) +
  theme(axis.text.r = element_blank())

Created on 2025-09-05 with reprex v2.1.1

@teunbrand teunbrand added this to the ggplot2 4.0.1 milestone Oct 20, 2025
thomasp85
thomasp85 approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 0f783ce into tidyverse:main Oct 27, 2025
13 checks passed
@teunbrand teunbrand deleted the fix_6574 branch October 27, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

ggplot2 4.0.1

Development

Successfully merging this pull request may close these issues.

r.axis.inside not work when axis.text.r is blank but axis.ticks.r is not

2 participants

@teunbrand @thomasp85